ci: Add a context for testing flatpak #818
Conversation
|
Although, this is less useful than it could be because |
|
Can we just provision a VM for it for now? |
|
We could; that's what the flatpak CI is doing now. I guess the thing that bothers me about that is that it's regressing to the old mindset of build-in-VM instead of build-in-container (and possibly run-in-VM after). |
|
That said, maybe it wouldn't be too hard to try to make a reusable script implementing that pattern, like I did for bubblewrap. Then we could copy that around for a while, and it'd give us some more real-world experience for making it declarative in rhci. |
|
Oh right, the other problem with that is flatpak's tests are uninstalled. So I'd have to port them. |
|
Hmm, how about we provision a VM and run it all in a privileged container there?
I think that pattern will be obsoleted by adding RPM support to rhci, right? Then you have a bona fide tree with your bits already installed. |
This was part of the philosophy behind https://wiki.gnome.org/Initiatives/GnomeGoals/InstalledTests - libraries like libostree don't need to replicate everything in unit tests, we can use the tests from our dependencies directly too. We'll also get API break coverage testing too.
|
Ok, done ⬆️ |
|
Oh heh right, not quite: Yep, the only sane thing to do is to change the flatpak tests to be installed. I'd like to do that for ostree too. |
| distro: fedora/25/atomic | ||
|
|
||
| tests: | ||
| - docker run --rm --privileged -v $(pwd):/srv/code registry.fedoraproject.org/fedora:25 /bin/sh -c "cd /srv/code && ./ci/flatpak.sh" |
There was a problem hiding this comment.
Can we also upload the test results?
artifacts:
- test-suite.logAnd in the flatpak.sh script, have something like:
trap '[ ! -f test-suite.log ] || cp test-suite.log /srv/code' ERR?
|
That's weird. The default docker backend is still devmapper for F25, right? Actually, looking at the output, I don't see |
|
Nice! The error is just flaky infra, so let's give it a try. |
|
☀️ Test successful - status-atomicjenkins |
This was part of the philosophy behind https://wiki.gnome.org/Initiatives/GnomeGoals/InstalledTests -
libraries like libostree don't need to replicate everything in unit tests, we
can use the tests from our dependencies directly too.
We'll also get API break coverage testing too.